Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if a metadata value looks like a url then display as a link #1137

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

jasquat
Copy link
Contributor

@jasquat jasquat commented Feb 29, 2024

Implements #1064

This will display values from metadata like a url as a link on the process instance show page.

Summary by CodeRabbit

  • New Features
    • Enhanced metadata display by automatically converting URLs into clickable links in the process instance view.

Copy link
Contributor

coderabbitai bot commented Feb 29, 2024

Warning

Rate Limit Exceeded

@jasquat has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 43 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 5ad582e and f8079b9.

Walkthrough

The recent changes involve introducing a function to validate URLs and enhancing the display of metadata in process instances by converting URLs into clickable links. These updates aim to improve user experience by enabling direct access to linked resources from the displayed metadata.

Changes

Files Change Summary
.../src/helpers.tsx Added isURL function to validate strings as URLs.
.../src/routes/ProcessInstanceShow.tsx Added formatMetadataValue to render metadata URLs as clickable links.

Related issues

  • Clickable URL if metadata #1064: The changes directly address the request for making URLs in process metadata clickable, enhancing user experience by allowing direct navigation from metadata.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 3

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 0565e63 and 2959f81.
Files selected for processing (2)
  • spiffworkflow-frontend/src/helpers.tsx (1 hunks)
  • spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx (3 hunks)
Additional comments: 1
spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx (1)
  • 559-559: The usage of formatMetadataValue within the metadata display logic is correct and aligns with the PR's objectives. It enhances the user interface by making URLs within metadata values clickable, improving accessibility and usability.

spiffworkflow-frontend/src/helpers.tsx Show resolved Hide resolved
spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx Outdated Show resolved Hide resolved
spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx Outdated Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 2959f81 and 5ad582e.
Files selected for processing (1)
  • spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx

@jasquat jasquat merged commit 32fbfa7 into main Mar 1, 2024
22 checks passed
@jasquat jasquat deleted the url-from-metadata branch March 1, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants