some additional fixes for the numeric range field

[jasquat]

Addresses #647 (comment)

Summary by CodeRabbit

• New Features

  • Enhanced the Numeric Range Field to display custom helper texts for minimum and maximum value validations.

• Bug Fixes

  • Improved form validation logic to correctly handle null values for minimum and maximum constraints.
  • Updated numeric input validation to support negative numbers.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates enhance the robustness and functionality of form validation and user interface components. Modifications include improved handling of null values in validation logic, an extension of a regex to support negative numbers, and the addition of user-friendly helper texts for numeric input fields. These changes ensure more accurate data validation and a better user experience.

Changes

File Path	Change Summary
.../CustomForm.tsx	Updated validation logic to handle null values using optional chaining.
.../helpers.tsx	Modified matchNumberRegex to allow negative numbers.
.../rjsf/custom_widgets/NumericRangeField/...	Added invalidText props for min and max inputs, set to helper texts.

---

Recent Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bd51222 and 630ced7.

Files selected for processing (3)

• spiffworkflow-frontend/src/components/CustomForm.tsx (1 hunks)
• spiffworkflow-frontend/src/helpers.tsx (1 hunks)
• spiffworkflow-frontend/src/rjsf/custom_widgets/NumericRangeField/NumericRangeField.tsx (2 hunks)

Additional comments not posted (4)

spiffworkflow-frontend/src/rjsf/custom_widgets/NumericRangeField/NumericRangeField.tsx (2)

169-169: Ensure invalidText and helperText are dynamically updated based on validation.

Please verify that the invalidText and helperText for the minimum input are dynamically updated based on the validation results to ensure accurate user feedback.

---

185-185: Ensure invalidText and helperText are dynamically updated based on validation.

Please verify that the invalidText and helperText for the maximum input are dynamically updated based on the validation results to ensure accurate user feedback.

spiffworkflow-frontend/src/helpers.tsx (1)

12-12: Validate the updated regex for numeric input.

Please ensure that the updated matchNumberRegex correctly handles all intended numeric formats, including negative numbers, without inadvertently allowing invalid formats.

spiffworkflow-frontend/src/components/CustomForm.tsx (1)

269-270: Refine numeric range validation to handle potential null values correctly.

Please verify that the updated validation logic using optional chaining (?.) correctly handles cases where min or max values might be null, ensuring robust validation under all conditions.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.