Return detailed error (incl. stack trace) instead of err.Error() string

[markusdosch]

In one of our projects, we are using the pkg/errors library. Errors created with this library can contain a stack trace. Unfortunately, when returning such errors from our build functions, extra information like stack traces are currently not being printed out.

With this change, errors created by pkg/errors are printed out in extended format (including stack trace).

"Normal" errors created with errros.New() or fmt.Errorf(...) are not affected, the output for them stays the same.

[coveralls]

Coverage remained the same at 99.677% when pulling 70d6d4f on markusdosch:errors into 9157bf8 on sarulabs:master.

[sarulabs]

This seems to be a good change.

But this pattern is also in two other places:

• di/containerSlayer.go

  Line 105 in 9157bf8

  return fmt.Errorf("could not close `%s`: %s", def.Name, err.Error())

• di/containerUnscopedGetter.go

  Line 51 in 9157bf8

  return nil, fmt.Errorf("could not get `%s` because %s", def.Name, err.Error())

And also here:

• di/containerGetter.go

  Line 155 in 9157bf8

  return " (with an error: " + err.Error() + ")"

  
  where fmt.Sprintf could be used.

Can you add these 3 modifications to your pull request ?

Thank you !

[markusdosch]

Hey @sarulabs , thanks for the fast reply & review! 😃 I just updated my PR with the changes you requested.

[sarulabs]

I created a new release v2.4.1 with your changes.

Thanks again for you contribution.