Fix node removal bug #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be used as `NodeEdge<NodeId>`, so these new derives would not break downstream codes.
Added tests of removal for nodes at various positions.
This new implementation passes all (newly added) removal tests.
saschagrunert
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeId::remove()NodeId::remove()NodeEdgeI'm currently working to add more assertions, examples, and tests (I'll make Pull Request later), and found that
NodeId::remove()has a bug.Tree becomes inconsistent after removing nodes.
(This can be checked by running tests at the commit 0a7046b.)
I added tests and re-implement
NodeId::remove(), and this version seems to work as expected.(I'm adding many debug assertions to this code on another branch, and all of these assertions did not fail.)
To make tests easy and more complete, I added
#[derive(PartialEq, Eq, Hash)]toNodeEdge<T>.This is non-breaking change.