Remove NodeId::new() and make NodeId::from_non_zero_usize() crate-local
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-local `NodeId` should not be crafted by the users. Users should get correct `NodeId` from accessors and `Arena::new_node()`. It is easy to store (since it implements `Copy` trait and has no lifetime restriction), and node access does not require direct integer index. Additionally, users cannot get internal index from `NodeId` in usual way. (They can guess the index, but it depends on hidden internal implementation, and it might be changed silently because it is hidden.) `NodeId::new()` and `NodeId::from_non_zero_usize()` is useless for users.
saschagrunert
approved these changes
Aug 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking change.
NodeIdshould not be crafted by the users.Users should get correct
NodeIdfrom accessors andArena::new_node().It is easy to store (since it implements
Copytrait and has no lifetime restriction), and node access does not require direct integer index.Additionally, users cannot get internal index from
NodeIdin usual way.(They can guess the index, but it depends on hidden internal implementation, and it might be changed silently because it is hidden.)
NodeId::new()andNodeId::from_non_zero_usize()is useless for users.