Implement FusedIterator for all iterator types
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All iterator types provided by this crate traverses nodes or edges, and they return `None` forever once the traversal is done. For such iterators, it is recommended to implement `FusedIterator` trait to make `iter.fuse()` efficient. See rustdoc for `core::iter::FusedIterator`.
|
clippy lint fails at the code I didn't modify. |
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
======================================
Coverage 88.5% 88.5%
======================================
Files 10 10
Lines 829 829
======================================
Hits 734 734
Misses 95 95 |
|
Yes, I'll fix it later on. Thank you! |
saschagrunert
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All iterator types provided by this crate traverses nodes or edges, and they return
Noneforever once the traversal is done.For such iterators, it is recommended to implement
FusedIteratortrait to makeiter.fuse()efficient.See rustdoc for
core::iter::FusedIterator.