Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New_Features] Adds recently added Assistant cost saving parameters #710

Merged

Conversation

qhenkart
Copy link
Contributor

.Describe the change
OpenAI quietly released a major upgrade of their Assistant's API which gives us vital cost management functionality with easy to use parameters

Provide OpenAI documentation link
(https://platform.openai.com/docs/api-reference/runs)

Describe your solution
Not much to mention, it simply adds the new parameters to the object

Tests
as these are just extra fields in the request and response object, it cannot really be tested with unit tests

Additional context
I purposely skipped some of the other new fields such as
Stream, which requires more infrastructure and should be it's own PR to define a properly abstracted streaming solution
I also skipped tool_choice and response_format, both because the documentation is not clear, and would require additional testing.

This PR is focused primarily on the very straight forward cost cutting parameters

@qhenkart qhenkart force-pushed the add-additional-request-options branch from b65c6c4 to 86c7e2a Compare April 15, 2024 07:08
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (774fc9d) to head (6b5c472).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   98.46%   98.67%   +0.21%     
==========================================
  Files          24       24              
  Lines        1364     1134     -230     
==========================================
- Hits         1343     1119     -224     
+ Misses         15        9       -6     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the PR!

@sashabaranov sashabaranov merged commit a42f519 into sashabaranov:master Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants