Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sasjs adapter min version #781

Closed
saramartinelli1992 opened this issue Feb 7, 2023 · 5 comments · Fixed by #791
Closed

sasjs adapter min version #781

saramartinelli1992 opened this issue Feb 7, 2023 · 5 comments · Fixed by #791
Assignees

Comments

@saramartinelli1992
Copy link

Hi,
I'm using this version of the sasjs adapter https://cdn.jsdelivr.net/npm/@sasjs/adapter@3/index.min.js
After the download I see that it's 5MB so I'm wondering if it's minimized because it's quite heavy and takes some time to load.

Thanks
Sara

@allanbowe
Copy link
Member

Hi Sara - latest version is this one: https://cdn.jsdelivr.net/npm/@sasjs/adapter@4.1.3/index.min.js

Which is 5.8mb, unfortunately.

The adapter was built as the main 'communication mechanism' between client apps and SAS, so does a lot more than just logon / make requests (the majority of browser based usage). The CLI and VS Code extension make further requirements of it.

Ultimately you should be able to save space by building your app using NodeJS / NPM rather than as a static web app + CDN - but appreciate that doesn't really solve your use case.

We'll look at what we can do to reduce the bundle size, perhaps we can do a build that is just SAS9, or just SASVIYA. Will investigate.

@saramartinelli1992
Copy link
Author

Hi Allan,
thanks for the update.
Just FYI the download link in the readme file is not updated with the latest version you shared with me.

allanbowe added a commit that referenced this issue Feb 7, 2023
@allanbowe
Copy link
Member

Thanks, fixed :-)

@allanbowe
Copy link
Member

New minified version of SAS 9 adapter is ~230kb :-)

@allanbowe
Copy link
Member

Turns out the massive filesize was due to leftover sourcemaps (doh), the regular adapter is now also down to 1.2mb

thanks very much for raising this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants