Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 258 #259

Merged
merged 11 commits into from
Feb 25, 2021
Merged

Issue 258 #259

merged 11 commits into from
Feb 25, 2021

Conversation

medjedovicm
Copy link
Member

@medjedovicm medjedovicm commented Feb 23, 2021

Issue

Fixes #258

Intent

Fixing the issue where the web approach did not work with debugging switched on.
Fixed resending requests mechanism.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • All unit tests are passing (npm test).
    image
  • All sasjs-cli unit tests are passing (npm test).
  • All sasjs-tests are passing (instructions available here).
    sasjs-tests

@saadjutt01 saadjutt01 merged commit 2cffc57 into master Feb 25, 2021
@saadjutt01 saadjutt01 deleted the issue-258 branch February 25, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web approach loginCallback
3 participants