Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-version-check): add Node version check, add package check to CI workflow #999

Merged
merged 9 commits into from
Sep 20, 2021
Merged

fix(node-version-check): add Node version check, add package check to CI workflow #999

merged 9 commits into from
Sep 20, 2021

Conversation

krishna-acondy
Copy link
Contributor

@krishna-acondy krishna-acondy commented Sep 19, 2021 •
edited
Loading

Issue

Fixes #884

Intent

Check Node.js version before installing the CLI.

Implementation

  • Moved checkNodeVersion implementation into package.json script.
  • Improved messaging within the Node version check script.
  • Added CI workflow step for testing the package install on Windows and Linux.

Before

image

After

image

Checks

  • Code is formatted correctly (npm run lint:fix).
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • Reviewer is assigned.

@krishna-acondy krishna-acondy marked this pull request as draft September 19, 2021 09:31
@krishna-acondy krishna-acondy marked this pull request as ready for review September 19, 2021 11:09
@allanbowe allanbowe merged commit 1fcf698 into main Sep 20, 2021
@allanbowe allanbowe deleted the node-version-fix branch September 20, 2021 06:33
@ghost
Copy link

ghost commented Sep 20, 2021

🎉 This PR is included in version 2.38.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Sep 20, 2021
@krishna-acondy krishna-acondy mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe approved these changes

@saadjutt01 saadjutt01 saadjutt01 approved these changes

@sabhas sabhas Awaiting requested review from sabhas

@VladislavParhomchik VladislavParhomchik Awaiting requested review from VladislavParhomchik

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent node version warnings when installing CLI
3 participants
@krishna-acondy @allanbowe @saadjutt01