Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assets dir はいらない #27

Closed
torounit opened this issue Jan 31, 2016 · 8 comments
Closed

assets dir はいらない #27

torounit opened this issue Jan 31, 2016 · 8 comments

Comments

@torounit
Copy link
Contributor

フレームワークなので、レポジトリ直下にsrcもしくはcssとかって置くべき。
@torounit
Copy link
Contributor Author

この場合scssですね

@torounit
Copy link
Contributor Author

assetsに入るべきはこの場合、ドキュメントのみで使う画像とかですかね。

@inc2734
Copy link
Member

inc2734 commented Jan 31, 2016

そういうものなんですね。確かに Foundation や Pure をみると assets ってないですね。Bootstrap はちょっと違いましたが。ドキュメントも直下に index.html ではなくて doc みたいなディレクトリに入れようかなと考えています。

@torounit
Copy link
Contributor Author

それだとgh-pagesめんどくない？

@inc2734
Copy link
Member

inc2734 commented Jan 31, 2016

はい、めんどそうなので手を付けてないですw

torounit added a commit to torounit/basis that referenced this issue Jan 31, 2016
@torounit
fix sass-basis#27
2952cf6
@torounit
Copy link
Contributor Author

Please merge!

@inc2734
Copy link
Member

inc2734 commented Jan 31, 2016

assets が何もかもなくなってるっぽい気がするのですが大丈夫ですかね…？
https://github.com/torounit/basis/tree/2952cf63472e67d4b79f9843e86b82d9f7cf22dc

@torounit
Copy link
Contributor Author

だめですだめですだめですすみませんcloseしました。

torounit added a commit to torounit/basis that referenced this issue Jan 31, 2016
@torounit
fix sass-basis#27
4d6f6c1
This was referenced Jan 31, 2016
Closed
Merged
inc2734 added a commit that referenced this issue Jan 31, 2016
@inc2734
Merge branch 'issues/#27-#25' of git://github.com/torounit/basis into…
d80072b 
… torounit-issues/#27-#25

# Conflicts:
#	assets/src/scss/foundation/_normalize.scss
#	gulpfile.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issues/#27 #25 torounit/basis
2 participants
@inc2734 @torounit