Fix bug in RecursiveAstVisitor #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the body of `visitParenthesizedExpression` was accidentally removed when the type parameter was removed from this class.
nex3
approved these changes
Jul 7, 2021
|
Should I wait for a Dart Sass release or should I work around this in the migrator to get out a release now? |
|
Either way is fine—you can also feel free to cut a Dart Sass release just for this if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the body of
visitParenthesizedExpressionwas accidentally removed when the type parameter was removed from this class.This will fix sass/migrator#202 once it's merged and we cut a new migrator release.