Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocol-version during embedded-host-node release #2097

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Update protocol-version during embedded-host-node release #2097

merged 2 commits into from
Sep 27, 2023

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Sep 27, 2023

run: echo "version=${GITHUB_REF##*/}" | tee --append "$GITHUB_OUTPUT"
run: |
echo "version=${GITHUB_REF##*/}" | tee --append "$GITHUB_OUTPUT"
echo "protocol_version=$(curl https://raw.githubusercontent.com/sass/sass/HEAD/spec/EMBEDDED_PROTOCOL_VERSION)" | tee --append "$GITHUB_OUTPUT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a risk that this will run into quota limits. We should either pass the GitHub token to it, or find a pre-existing action we can use to download a file with token support. (We could also just use actions/checkout but that'll take longer than necessary.)

run: echo "version=${GITHUB_REF##*/}" | tee --append "$GITHUB_OUTPUT"
run: |
echo "version=${GITHUB_REF##*/}" | tee --append "$GITHUB_OUTPUT"
echo "protocol_version=$(curl -fsSL -H "Authorization: Bearer ${{ github.token }}" https://raw.githubusercontent.com/sass/sass/HEAD/spec/EMBEDDED_PROTOCOL_VERSION)" | tee --append "$GITHUB_OUTPUT"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: curl -fsSL is commonly used in scripting:

-f: Fail fast with no output at all on server errors.
-s: Silent or quiet mode. Do not show progress meter or error messages.
-S: When used with -s, --silent, it makes curl show an error message if it fails.
-L: If the server reports that the requested page has moved to a different location (indicated with a Location: header and a 3XX response code), this option will make curl redo the request on the new place.

@nex3
Copy link
Contributor

nex3 commented Sep 27, 2023

Thanks!

@nex3 nex3 merged commit 9177f14 into sass:main Sep 27, 2023
28 checks passed
@ntkme ntkme deleted the update-protocol-version branch September 27, 2023 21:00
jgerigmeyer added a commit to oddbird/dart-sass that referenced this pull request Oct 12, 2023
* feature.color-4: (30 commits)
  Update for `lch()` tests (sass#2108)
  Add support for relative color syntax (sass#2112)
  Update for `oklab()` tests (sass#2094)
  Poke CI
  Cut a release (sass#2107)
  Implement first class mixins (sass#2073)
  Fix a race condition preventing embedded compiler to shutdown after a protocol error (sass#2106)
  Switch to the GitHub-hosted MacOS ARM64 runner (sass#2103)
  Update the version of Sass used by the website on release (sass#2102)
  Bump actions/checkout from 3 to 4 (sass#2088)
  Bump docker/setup-qemu-action from 2 to 3 (sass#2089)
  Implement support for the relative color syntax of CSS Color 5 (sass#2098)
  Rephrase errors for numbers that must be unitless or % (sass#2101)
  Forbid LLM contributions (sass#2100)
  Update protocol-version during embedded-host-node release (sass#2097)
  Deprecate Deprecation.calcInterp (sass#2096)
  Avoid useless allocations for interpolations without maps (sass#2095)
  Fix an error during embedded compiler shutdown (sass#2092)
  Cut a release (sass#2090)
  Expose the containing URL to importers under some circumstances (sass#2083)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants