Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing space after a semi-colon if interpolation used #1092

Closed
mgol opened this issue Apr 10, 2015 · 3 comments · Fixed by #1181
Closed

Missing space after a semi-colon if interpolation used #1092

mgol opened this issue Apr 10, 2015 · 3 comments · Fixed by #1181
Assignees
@mgreter
Labels
Bug - Confirmed Bug - Whitespace Dev - PR Ready Dev - Test Written
Milestone
3.2.3

Comments

@mgol
Copy link

mgol commented Apr 10, 2015

The following SCSS:

a {
    $s: "";
    transform: translateZ(0) #{$s};
}

Ruby Sass 3.4.13 transforms it to:

a {
  transform: translateZ(0) ; }

libsass 3.2.0-beta.5 transforms it to:

a {
  transform: translateZ(0) ;}

Note the missing space after a semi-colon.

If interpolation (#{}) is removed, the space appears.
@xzyfer xzyfer added this to the 3.4 milestone Apr 11, 2015
@xzyfer xzyfer mentioned this issue Apr 11, 2015
Merged
@xzyfer
Copy link
Contributor

xzyfer commented Apr 11, 2015

Spec added sass/sass-spec#323

@xzyfer xzyfer mentioned this issue Apr 26, 2015
Merged
@HamptonMakes
Copy link
Member

I can confirm that this issue has been solved in the latest release.

@HamptonMakes
Copy link
Member

Aaaand, I'm mistaken.

@HamptonMakes HamptonMakes reopened this Apr 29, 2015
@mgreter mgreter modified the milestones: 3.2.3, 3.4 May 8, 2015
@mgreter mgreter self-assigned this May 8, 2015
mgreter added a commit to mgreter/libsass that referenced this issue May 8, 2015
@mgreter
Fix white-space error with nested output style
daeaefa 
Fixes sass#1092
@mgreter mgreter mentioned this issue May 8, 2015
Merged
mgreter added a commit to mgreter/libsass that referenced this issue May 8, 2015
@mgreter
Fix white-space error with nested output style
2c65fdd 
Fixes sass#1092
mgreter added a commit to mgreter/libsass that referenced this issue May 9, 2015
@mgreter
Fix white-space error with nested output style
aee4b96 
Fixes sass#1092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgreter mgreter

Labels
Bug - Confirmed Bug - Whitespace Dev - PR Ready Dev - Test Written
Projects
None yet
Milestone
3.2.3
Development

Successfully merging a pull request may close this issue.

Fix white-space error with nested output style mgreter/libsass
4 participants
@HamptonMakes @mgreter @xzyfer @mgol