Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declaration does not declare anything [-Wmissing-declarations] #2690

Closed
bep opened this issue Jul 5, 2018 · 4 comments
Closed

declaration does not declare anything [-Wmissing-declarations] #2690

bep opened this issue Jul 5, 2018 · 4 comments

Comments

@bep
Copy link
Contributor

bep commented Jul 5, 2018

This is from using https://github.com/wellington/go-libsass/tree/master/libs (latest version) -- i.e. CGO from Hugo, but I assume this is a problem in LibSass itself:

# github.com/gohugoio/hugo/vendor/github.com/wellington/go-libsass/libs
In file included from cencode.c:2:
../vendor/github.com/wellington/go-libsass/libs/../libsass-build/cencode.c:50:5: warning: declaration does not declare anything [-Wmissing-declarations]
../vendor/github.com/wellington/go-libsass/libs/../libsass-build/cencode.c:64:5: warning: declaration does not declare anything [-Wmissing-declarations]
@nschonni
Copy link
Collaborator

nschonni commented Jul 5, 2018

Those lines look like they are compiler directives for the Microsoft C++ compiler
https://github.com/sass/libsass/blob/master/src/cencode.c#L49-L51

That is a file from an external project if you look in the header, but I'm not sure if this is something that needs to be addressed or if it is just your toolchain

@bep
Copy link
Contributor Author

bep commented Jul 5, 2018

I'm using Clang on MacOS and Linux and GCC on WIndows, and I'm getting the same warnings on all platforms. But I will investigate a little more.

@bep
Copy link
Contributor Author

bep commented Oct 5, 2018

@xzyfer could you tag a minor release with this fix in it?

@xzyfer
Copy link
Contributor

xzyfer commented Nov 11, 2018

@bep tagged 3.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants