Make source_map_embed
independent of source_map_file
#1516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should IMO address #885
The
source_map_embed
option no longer needssource_map_file
to be present. We currently always return a source-map on the C-API level (AFAIR), but from the semantics we do not guarantee that, when neither of two main options are set.source_map_embed
has higher priority andsource_map_contents
doesn't do anything on its own.So we have these options in regard of source-maps:
source_map_file
: libsass only adds the sourceMappingURL to the outputsource_map_embed
: generate sourceMappingURL with embedded source-mapsource_map_contents
: adds thesourceContents
array to the source-mapomit_source_map_url
: suppress any sourceMappingURL output