Fix some segfaults caused by the parser being too forgiving #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forcing whitespace trimming makes it impossible to match some Ruby Sass error messages.
xzyfer
force-pushed
the
fix-segfault
branch
2 times, most recently
from
4e304e0
to
1626cf9
Compare
Originally reported by @MrTuxracer
Originally reported by @MrTuxracer
xzyfer
added a commit
that referenced
this pull request
May 2, 2017
* Make whitespace trimming in parser error messages optional Forcing whitespace trimming makes it impossible to match some Ruby Sass error messages. * Fix segault when support conditions is missing Originally reported by @MrTuxracer * Fix segault when while predicate is missing Originally reported by @MrTuxracer
xzyfer
added a commit
that referenced
this pull request
May 2, 2017
* Make whitespace trimming in parser error messages optional Forcing whitespace trimming makes it impossible to match some Ruby Sass error messages. * Fix segault when support conditions is missing Originally reported by @MrTuxracer * Fix segault when while predicate is missing Originally reported by @MrTuxracer
xzyfer
added a commit
that referenced
this pull request
May 2, 2017
* Make whitespace trimming in parser error messages optional Forcing whitespace trimming makes it impossible to match some Ruby Sass error messages. * Fix segault when support conditions is missing Originally reported by @MrTuxracer * Fix segault when while predicate is missing Originally reported by @MrTuxracer
xzyfer
added a commit
that referenced
this pull request
May 2, 2017
* Make whitespace trimming in parser error messages optional Forcing whitespace trimming makes it impossible to match some Ruby Sass error messages. * Fix segault when support conditions is missing Originally reported by @MrTuxracer * Fix segault when while predicate is missing Originally reported by @MrTuxracer
xzyfer
added a commit
that referenced
this pull request
May 2, 2017
* Make whitespace trimming in parser error messages optional Forcing whitespace trimming makes it impossible to match some Ruby Sass error messages. * Fix segault when support conditions is missing Originally reported by @MrTuxracer * Fix segault when while predicate is missing Originally reported by @MrTuxracer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported by @MrTuxracer via HackerOne.
Spec sass/sass-spec#1103