Fix segfault with invalid map keys #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally reported by @MrTuxracer via HackerOne. The changed to using even sized lists to represent maps during the parse stage inadvertently removed certain parser-time error guarantees. The results being that invalid keys could make their way into the lists and cause segfaults during eval. This PR adds parser-time error handling for the most likely error case. Spec sass/sass-spec#1104
xzyfer
added a commit
that referenced
this pull request
May 2, 2017
Originally reported by @MrTuxracer via HackerOne. The changed to using even sized lists to represent maps during the parse stage inadvertently removed certain parser-time error guarantees. The results being that invalid keys could make their way into the lists and cause segfaults during eval. This PR adds parser-time error handling for the most likely error case. Spec sass/sass-spec#1104
xzyfer
added a commit
that referenced
this pull request
May 2, 2017
Originally reported by @MrTuxracer via HackerOne. The changed to using even sized lists to represent maps during the parse stage inadvertently removed certain parser-time error guarantees. The results being that invalid keys could make their way into the lists and cause segfaults during eval. This PR adds parser-time error handling for the most likely error case. Spec sass/sass-spec#1104
xzyfer
added a commit
that referenced
this pull request
May 2, 2017
Originally reported by @MrTuxracer via HackerOne. The changed to using even sized lists to represent maps during the parse stage inadvertently removed certain parser-time error guarantees. The results being that invalid keys could make their way into the lists and cause segfaults during eval. This PR adds parser-time error handling for the most likely error case. Spec sass/sass-spec#1104
xzyfer
added a commit
that referenced
this pull request
May 2, 2017
Originally reported by @MrTuxracer via HackerOne. The changed to using even sized lists to represent maps during the parse stage inadvertently removed certain parser-time error guarantees. The results being that invalid keys could make their way into the lists and cause segfaults during eval. This PR adds parser-time error handling for the most likely error case. Spec sass/sass-spec#1104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported by @MrTuxracer via HackerOne.
The changed to using even sized lists to represent maps during the
parse stage inadvertently removed certain parser-time error
guarantees. The results being that invalid keys could make their
way into the lists and cause segfaults during eval.
This PR adds parser-time error handling for the most likely error
case.
Spec sass/sass-spec#1104