Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only migrate to slash-list in a non-plain-CSS context #33

Closed
jathak opened this issue Apr 23, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@jathak
Copy link
Member

commented Apr 23, 2019

Actually, looking at these examples, they're really hard on the eyes. After this lands, can we make the migrator smart enough to only migrate to slash-list() in a non-plain-CSS context? Basically, we should generate slash-list() only if either _isDivisionAllowed is true or one of the arguments (possibly deeply-nested) is an interpolation expression.

Originally posted by @nex3 in #17

@jathak jathak added the division label Apr 23, 2019

@nex3 nex3 referenced this issue Apr 30, 2019

Closed

Migrate /-as-division to the divide() function #37

4 of 4 tasks complete

jathak added a commit that referenced this issue May 14, 2019

Improvements to the division migrator
Resolves #32 and resolves #33.

@jathak jathak closed this in #41 May 15, 2019

jathak added a commit that referenced this issue May 15, 2019

Improvements to the division migrator (#41)
* Improvements to the division migrator

Resolves #32 and resolves #33.

* Refactor special color function handle into fn

* Fix remaining comments

* Add comment and changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.