Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag to forward all members from the entrypoint #47

Closed
nex3 opened this issue May 16, 2019 · 0 comments · Fixed by #72
Closed

Add a flag to forward all members from the entrypoint #47

nex3 opened this issue May 16, 2019 · 0 comments · Fixed by #72
Labels
enhancement New feature or request module system Part of the module system migrator

Comments

@nex3
Copy link
Contributor

nex3 commented May 16, 2019

When running the migrator on a library, authors will usually want to expose all the members that library defines from the library's entrypoint file (that is, the file passed initially to the migrator). The migrator should support a flag to do this automatically by @forwarding all the files that define public names that are transitively imported by the migrator.
@nex3 nex3 added enhancement New feature or request module system Part of the module system migrator labels May 16, 2019
@nex3 nex3 mentioned this issue May 16, 2019
Closed
jathak added a commit that referenced this issue Aug 1, 2019
@jathak
Add flag for forwarding members from entrypoint
52c6b0a 
Resolves #47.

Adds a new flag `--forward` which can be `none` (default), `all`, or
`prefixed`.

If `--forward=all`, all global members from dependencies will be
forwarded from the entrypoint.

If `--forward=prefixed`, only members that were previously prefixed with
the value of `--remove-prefix` will be forwarded.
@jathak jathak mentioned this issue Aug 1, 2019
Merged
@jathak jathak closed this as completed in #72 Aug 2, 2019
jathak added a commit that referenced this issue Aug 2, 2019
@jathak
Add flag for forwarding members from entrypoint (#72)
f5575ea 
* Add flag for forwarding members from entrypoint

Resolves #47.

Adds a new flag `--forward` which can be `none` (default), `all`, or
`prefixed`.

If `--forward=all`, all global members from dependencies will be
forwarded from the entrypoint.

If `--forward=prefixed`, only members that were previously prefixed with
the value of `--remove-prefix` will be forwarded.

* Resolve code review comments

* Fix imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request module system Part of the module system migrator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add flag for forwarding members from entrypoint sass/migrator
1 participant
@nex3