Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodejs v14 Support added with node-sass 4.14.0 #2895

Closed
sxwebdev opened this issue Apr 21, 2020 · 15 comments
Closed

Nodejs v14 Support added with node-sass 4.14.0 #2895

sxwebdev opened this issue Apr 21, 2020 · 15 comments

Comments

@sxwebdev
Copy link

@sxwebdev sxwebdev commented Apr 21, 2020

Hello. When there will be support for nodejs 14 ? At the moment, on Windows 10 x64 installation is not possible.

@sxwebdev sxwebdev changed the title node v14 nodejs v14 Apr 21, 2020
@saper
Copy link
Member

@saper saper commented Apr 21, 2020

Do not upgrade to the new node engine before making sure it works. And you can always compile on your own.

Loading

@nschonni nschonni changed the title nodejs v14 Nodejs v14 Support Apr 21, 2020
@nschonni nschonni pinned this issue Apr 21, 2020
@nschonni
Copy link
Contributor

@nschonni nschonni commented Apr 21, 2020

As with previous major releases, there are several pieces that need to be done before a 4.14.0 is released with support #2632
I've pinned this issue for visibility

Loading

@nschonni
Copy link
Contributor

@nschonni nschonni commented Apr 22, 2020

Reopening till the release is cut

Loading

@nschonni nschonni reopened this Apr 22, 2020
@nschonni
Copy link
Contributor

@nschonni nschonni commented Apr 22, 2020

@xzyfer the only other thing that I think we might want to land for 4.14.0 is #2769
If you want to manually fix that when you bump before cutting the release

Loading

@nschonni nschonni added the 4.14 label Apr 22, 2020
@xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Apr 22, 2020

I've been putting of rebuilding all the binaries but I guess I can bite the bullet 👍

Loading

@xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Apr 22, 2020

I've kicked off the 4.14.0 binary build, and tagged the release including #2769.

Loading

@xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Apr 22, 2020

Linux, Alpine, OSX, and Windows binaries are built and uploaded. Will publish a release in the morning unless @nschonni is feeling up to it whilst Australia sleeps.

Loading

@JohnnyFun
Copy link

@JohnnyFun JohnnyFun commented Apr 22, 2020

Thanks for the quick update. Works for me now with node v14. Just had to put python 2.7 on my path and all went smoothly.

Loading

@billinghamj
Copy link

@billinghamj billinghamj commented Apr 23, 2020

Would it be possible to get that release published please? :)

Loading

@xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Apr 23, 2020

Whoops knew I forgot something. Just published as v4.14.0.

Loading

@xzyfer xzyfer closed this Apr 23, 2020
@billinghamj
Copy link

@billinghamj billinghamj commented Apr 23, 2020

Thank you! 😄

Loading

@billinghamj
Copy link

@billinghamj billinghamj commented Apr 23, 2020

Oddly it's appearing on yarn but not npm. Not sure if that's normal - maybe just needs time to sync

Loading

@DmitryOlkhovoi

This comment was marked as off-topic.

@saper

This comment was marked as off-topic.

@DmitryOlkhovoi

This comment was marked as off-topic.

@sass sass locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants