This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
chore: Remove CI for unsupported Node versions #2970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
force-pushed
the
unsupported-CI
branch
from
4af0dea
to
c3eeb09
Compare
|
@xzyfer any clue why the sass.type tests would be failing on Node 14 only? I think this was the issue I ran into before on my v5-lite branch |
|
Oh, right, I think I hit this and tried to fix this in the other branch. the |
|
OK, not the |
nschonni
force-pushed
the
unsupported-CI
branch
from
1da662c
to
1f6b7f8
Compare
This reverts commit 1f6b7f8.
|
Closing since landed version pinning to 14.5 for now. New PR should be sent to fix test and unpin |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying a larger branch/PR for #2965, but ended up having too much diff when I hit an issues. Will just submit these in smaller chunks for now and figure out what to cherry-pick from v5 separately