Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Prepare libsass 3.3: fix tests and build parameters #1146

Merged
merged 3 commits into from
Sep 16, 2015
Merged

Conversation

saper
Copy link
Member

@saper saper commented Sep 16, 2015

Those changes are not affecting libsass 3.2.5
and can be merged before libsass 3.3 hits the tree.

Introduce libsass version checking in cli.js
and skip the test if running with libsass 3.2.5
or older.
If compiling using the debug build of node
-DDEBUG and -D_DEBUG flags are automatically
added.

This causes libsass to produce additional
debugging output that may interfere with
tests.

Once this is resolved, this can be reverted.

Reported-as: sass/libsass#1518
@xzyfer
Copy link
Contributor

xzyfer commented Sep 16, 2015

👍🚢
On 16 Sep 2015 19:49, "Marcin Cieślak" notifications@github.com wrote:

Those changes are not affecting libsass 3.2.5

and can be merged before libsass 3.3 hits the tree.

You can view, comment on, or merge this pull request online at:

#1146
Commit Summary

  • Test against a hopefully correct source map output
  • includedFiles returns an array in no particular order
  • Exclude -DDEBUG from the libsass build

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1146.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants