Code: Rescue from Segmentation Fault (#361)

[am11]

Fixes #361.

[dburrows]

+1

[kairun]

+1

[johnraz]

👍

[paazmaya]

+1

[mgol]

This fixes sass/libsass#454.

[jasonsanjose]

+1 works for me on mac

[am11]

@nschonni, sorry for bothering you. Don't know who else to ping here, since @andrew isn't maintaining this repo anymore. :(

Any chance this and the other one get merged soon?

Also, there are other source map related matters need fixes: #380 and #379. For that matter, when would be the good time to update the libsass sub-module to its head commit?

[rryter]

same question as @am11, any chance this will be merged soon?

[keithamus]

Can anyone confirm this actually works? There are no downsides to this?

[am11]

@keithamus, Yes:

1. I can confirm it actually works and it doesn't break any test case.
2. Segmentation fault on undefined mixin libsass#446 (comment)
3. Sass maps cause a segmentation fault libsass#454 (comment)

There may be more to wit, but I think this would suffice.

[laurelnaiad]

Works for me on OSX. Couldn't really believe my eyes when my build process reported an error, recovered, and stayed alive instead of bombing! :) Anxiously awaiting this getting into a release.

[andrew]

Thanks @am11, I've merged this in now, we'll work towards updating the binaries for each platform and getting a new release out soon.

[am11]

Thank you @andrew. Looking forward to the next release. 👍

[laurelnaiad]

Yay!!! Thanks, @andrew!

EDIT: Doh! Of course thank you especially @am11!

[piotrkulpinski]

Hi guys,
any chance there will be a new release containing this fix soon?

[aminnaggar-fuzzy]

I can still reproduce the issue, is this fixed? 😕