Move coverage script to Makefile

[kevva]

Also includes some cleanup of unnecessary files in .gitignore which should belong
in a global .gitignore.

[am11]

Awesome! 👍

[kevva]

This shouldn't be needed either. If that's needed it means that tests are failing/are badly written.

[am11]

Oh yes! (unlink!!) I think it was due to the faulty libsass code during the testing. :)

[coveralls]

Changes Unknown when pulling 17e11ae on kevva:coverage into * on sass:master*.

[am11]

Perfect! Coverage 95%! 👍

@andrew, LGTM!

[kevva]

It's only testing the API though, not the CLI. We can't run the bin folder through jscoverage because the binaries lives there too.

[andrew]

@kevva Can you re-add npm-debug.log to that file? In my experience we can't assume every contributor has a good global .gitignore set up, theres no harm in leaving those entries in there so we don't accidently get those files added in a PR.

[kevva]

@andrew, there's *.log at the top :).

[andrew]

Ah, good spot, code review on mobile is tricky!

[am11]

LOL! That's true. Most honest mistakes transpire due to mobile technology.

[nschonni]

👎 Makefiles don't work on Windows, this is why we had the NPM and node scripts

[kevva]

This is only for the coverage stuff which is used by Travis anyway. That's why I kept make test out of the npm test script.

Another solution is to move the whole test suite to gulp or something. Anything that's more reliable and pretty than writing shell scripts using shelljs.

[nschonni]

The coverage can also be setup on Windows with AppVeyor, but not if we use a Makefile.
Sorry if I'm coming off as a jerk, but now we have to maintain a Makefile + the NPM scripts for no apparent benefit.

[kevva]

No problem. I'm kinda agreeing with you. It's not ideal to have both those scripts and a Makefile. But we should aim to replace those scripts with something better. The Makefile could work on Windows if we used nmake. As an alternative I'm up for using gulp.

[nschonni]

Yeah, I didn't do Grunt/Gulp before because there was no pressing need at the time. Now that there are more people working, it might be good for that to be revisited.

[andrew]

I'm still not a fan of grunt/gulp, npm scripts solves things in a simple way.

I completely forgot about makefiles on windows too 😦

[keithamus]

👍 for using npm scripts over grunt (http://blog.keithcirkel.co.uk/why-we-should-stop-using-grunt/)

[kevva]

+1 for using anything over grunt. That article got so many facts wrong about gulp though and shouldn't be treated as an argument for stop using it (not saying we should use gulp here though).