Reduce the size of the Black Lives Matter banner #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sass-lang ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Most of the text here is outdated at this point. The Sass core team wants to keep the banner itself both for its political purpose and because it's been pragmatically effective at getting racists to refuse to use Sass.
Goodwine
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
I that it looks weird having the top and bottom black bars having different sizes, so I started playing with the UI and I think if you remove margin-bottom: var(--sl-gutter);, then it'll look better.
This is what I mean:
Deleting that value makes it look better, but you lose the bottom margin at the end of the page for the footer. I think that the margin should change so it only affects the footer.
|
I'd like to avoid making other design changes in this PR. It may be worth sending a separate PR for it, but it's probably a good idea to loop in @jina (the original designer) to get an expert opinion. |
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
Most of the text here is outdated at this point. The Sass core team wants to keep the banner itself both for its political purpose and because it's been pragmatically effective at getting racists to refuse to use Sass.
asaf400
pushed a commit
to asaf400/ass-site
that referenced
this pull request
Apr 18, 2024
Most of the text here is outdated at this point. The Sass core team wants to keep the banner itself both for its political purpose and because it's been pragmatically effective at getting racists to refuse to use Sass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the text here is outdated at this point. The Sass core team
wants to keep the banner itself both for its political purpose and
because it's been pragmatically effective at getting racists to refuse
to use Sass.