Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark a reference combinator spec as ending at 3.4. #1133

Merged
merged 3 commits into from
Jun 9, 2017

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jun 2, 2017

Skip ruby-sass

@xzyfer
Copy link
Contributor

xzyfer commented Jun 2, 2017

It's worth noting that removing support for reference combinators without adding support for the >>> combinator will prevent Sass working with Angular. More details in

sass/libsass#2378 and sass/sass#2266

nex3 added a commit to sass/sass that referenced this pull request Jun 2, 2017
@nex3
Copy link
Contributor Author

nex3 commented Jun 2, 2017

According to this Chrome platform status page:

Shadow-Piercing descendant combinator, '/deep/' (aka '>>>'), including '::shadow' pseudo elements, are being deprecated.

However, the CSS Scoping 1 spec, which was updated today, still includes >>>. @tabatkins, can you provide some more context here? Is >>> deprecated or not? Is it supported in Chrome? Will it continue to be?

@nex3 nex3 force-pushed the no-reference-combinator branch from 2fee9f4 to 1349088 Compare June 2, 2017 05:50
@nex3 nex3 force-pushed the no-reference-combinator branch from 1349088 to 718306d Compare June 2, 2017 05:56
@tabatkins
Copy link

Deprecated in style sheets; it's no longer allowed there per spec. Still allowed in querySelector()/etc.

@nex3
Copy link
Contributor Author

nex3 commented Jun 5, 2017

In that case, it sounds like Angular should no longer be using either /deep/ or >>> in their style sheets, so we shouldn't feel obligated to support them.

@tabatkins
Copy link

Yup, exactly.

@nex3 nex3 merged commit d0eba85 into master Jun 9, 2017
@nex3 nex3 deleted the no-reference-combinator branch June 9, 2017 00:12
@luchillo17
Copy link

@nex3 Mind if i ask, if they remove such selectors for nested items, with what should they replace it?

@tabatkins
Copy link

Whatever they're already using to make it work in browsers other than Chrome, presumably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants