Add specs for load-css() #1417
Merged
Add specs for load-css() #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshahan
reviewed
Jun 28, 2019
| <===> nested/parent_selector/_other.scss | ||
| b { | ||
| // This & should *not* refer to the `a` in `input.scss`, because the CSS is | ||
| // resolved context-independently. |
There was a problem hiding this comment.
I'm having trouble seeing what this is testing. If this did refer to the a in input.scss what would you expect output.css to contain?
There was a problem hiding this comment.
If it referred to a, it would be equivalent to
a {
b {
c & {x: y}
}
}which would compile to
c a b {
x: y;
}This is an issue that actually comes up in practice fairly frequently with nested @imports.
nshahan
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip dart-sass]