Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add error for non-int str-insert index #1439

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions spec/core_functions/string/insert.hrx
Original file line number Diff line number Diff line change
Expand Up @@ -250,11 +250,6 @@ Error: argument `$index` of `str-insert($string, $insert, $index)` must be a num

<===>
================================================================================
<===> error/decimal/options.yml
---
:todo:
- sass/libsass#2921

<===> error/decimal/input.scss
a {b: str-insert("", "", 0.5)}

Expand All @@ -266,6 +261,14 @@ Error: $index: 0.5 is not an int.
'
input.scss 1:7 root stylesheet

<===> error/decimal/error-libsass
Error: $index: 0.500000 is not an int
on line 1:7 of input.scss, in function `str-insert`
from line 1:7 of input.scss
>> a {b: str-insert("", "", 0.5)}

------^

<===>
================================================================================
<===> error/too_few_args/input.scss
Expand Down