-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test for testing --run-todo flag #1492
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3ab557c
wip
rambleraptor 541c99f
changing metadata test
rambleraptor f60dec6
different fix
rambleraptor a7f04f0
trying to get tests to work
rambleraptor 549e210
test passes
rambleraptor 4429d40
default implementation is not set to 'sass'
rambleraptor d62f1fd
typed that wrong
rambleraptor 411fe66
PR comments
rambleraptor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
<===> no_todo/input.scss | ||
p { | ||
color: #ff8000; | ||
} | ||
|
||
<===> no_todo/output.css | ||
input: ["--precision", "10", "-t", "expanded", "input.scss"] | ||
file: p { | ||
color: #ff8000; | ||
} | ||
|
||
<===> | ||
============================================================= | ||
<===> todo/options.yml | ||
--- | ||
:todo: | ||
- sass/sass#0000 | ||
|
||
<===> todo/input.scss | ||
p { | ||
color: #ff8000; | ||
} | ||
|
||
<===> todo/output.css | ||
input: ["--precision", "10", "-t", "expanded", "input.scss"] | ||
file: p { | ||
color: #ff8000; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These
run_command
invocations have a lot of boilerplate... consider factoring out a helper function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely agree! I've already got a PR going for the next test, so I'll make a helper function there.