Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for @for inside property declaration #1665

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Add test for @for inside property declaration #1665

merged 1 commit into from
Jun 2, 2021

Conversation

jathak
Copy link
Member

@jathak jathak commented Jun 2, 2021 •
edited
Loading

[skip dart-sass]

@jathak jathak requested a review from nex3 June 2, 2021 20:43
@jathak jathak changed the title Create a new top-level directory for expressions Add test for @for inside property declaration Jun 2, 2021
@jathak jathak mentioned this pull request Jun 2, 2021
Merged
nex3
nex3 approved these changes Jun 2, 2021
View reviewed changes
spec/directives/for.hrx Outdated
<===> in_declaration/input.scss
a {
b: {
@for $i from 1 through 5 {c: $i;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: unnecessary semicolon.

@jathak jathak merged commit db56987 into master Jun 2, 2021
@jathak jathak deleted the fix_for_loop branch June 2, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jathak @nex3