-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calc functions tests #1912
Calc functions tests #1912
Conversation
Nit, you want to add You can also run |
76ef20e
to
440d165
Compare
440d165
to
56fc702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'll leave it to Jen to do a final approval.
Note that if you get an approval, you should not submit until both PRs are approved since they should be merged roughly at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the spec (both ours and the CSS spec), I realize now that I mistakenly had the impression (and then shared that with you) that these new math functions have to be contained within another calc
to work (MDN was unhelpful here its examples for sqrt
and most of the other functions did have them nested).
In actuality, code like
a {
b: sqrt(4);
}
is valid and the sqrt(4)
should simplify to 2.
Given that, most of these tests should just have sqrt
without a calc
wrapping them (maybe have one test like that to test the nesting). They otherwise look good (though I'll wait to give final approval until all of the functions are implemented/tested).
Sorry for the confusion!
56fc702
to
13e578c
Compare
13e578c
to
d787dea
Compare
85c6a49
to
d24402a
Compare
26db9d2
to
05bcabe
Compare
9cc3e76
to
11ddcde
Compare
11ddcde
to
7c5e152
Compare
7c5e152
to
f3d59c7
Compare
f3d59c7
to
b728a9a
Compare
Context: Calc functions proposal
[skip dart-sass]