Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot load such file -- sprockets/sass_template #64

Open
schneems opened this issue Jun 21, 2016 · 4 comments
Open

cannot load such file -- sprockets/sass_template #64

schneems opened this issue Jun 21, 2016 · 4 comments

Comments

@schneems
Copy link
Contributor

Do you know where require "sprockets/sass_template" is supposed to be coming from?

LoadError: cannot load such file -- sprockets/sass_template
/Users/richardschneeman/.gem/ruby/2.4.0/gems/activesupport-5.0.0.rc1/lib/active_support/dependencies.rb:293:in `require'
/Users/richardschneeman/.gem/ruby/2.4.0/gems/activesupport-5.0.0.rc1/lib/active_support/dependencies.rb:293:in `block in require'
/Users/richardschneeman/.gem/ruby/2.4.0/gems/activesupport-5.0.0.rc1/lib/active_support/dependencies.rb:259:in `load_dependency'
/Users/richardschneeman/.gem/ruby/2.4.0/gems/activesupport-5.0.0.rc1/lib/active_support/dependencies.rb:293:in `require'
/Users/richardschneeman/.gem/ruby/2.4.0/gems/sassc-rails-1.2.1/lib/sassc/rails/template.rb:2:in `<top (required)>

Btw I maintain sprockets, sprockets-rails, and sass-rails now. Happy to work together to make the sassc-rails experience better in the future. For now i'm trying to get it to work with https://github.com/codetriage/codetriage and running into this error.

Here's my bundle list https://gist.github.com/schneems/fdee966b8caf7556a79e4fcb23d7b41c

@schneems
Copy link
Contributor Author

Ahh, it looks like those things got taken out in sprockets 4.x here's the 3.x branch https://github.com/rails/sprockets/blob/3.x/lib/sprockets/sass_template.rb

Any ideas on backwards compatibility changes for sprockets 4? I kinda fell into this maintainer role, there's lots of catching up to do. I think instead of using SassTemplate we can directly use SassProcessor

@bolandrm
Copy link
Member

That sounds like a reasonable place to start, although for now I'd like to at least maintain support for sprockets 2 / 3 as well.

As far as future compatibility goes, there was a push to get LibSass integrated into sprockets and the default sass-rails (rails/sass-rails#349). This will be a lot easier for me to finish once we get to upgrading our project to Rails 5 / sprockets 4.

@schneems
Copy link
Contributor Author

I'm working to add deprecations for all of these code points in sprockets 3 right now. I've got some ideas on a patch that would work for this to work with sprockets 2, 3 & 4 (all of which are currently supported via me currently).

schneems added a commit to rails/sprockets that referenced this issue Jun 21, 2016
Found they're bing used by `sassc-rails` sass/sassc-rails#64.
schneems added a commit to rails/sprockets that referenced this issue Jun 21, 2016
Found they're bing used by `sassc-rails` sass/sassc-rails#64.
schneems added a commit to rails/sprockets that referenced this issue Jun 21, 2016
Found they're bing used by `sassc-rails` sass/sassc-rails#64.
schneems added a commit to rails/sprockets that referenced this issue Jun 22, 2016
Found they're bing used by `sassc-rails` sass/sassc-rails#64.
schneems added a commit to rails/sprockets that referenced this issue Jun 22, 2016
Found they're bing used by `sassc-rails` sass/sassc-rails#64.
@schneems
Copy link
Contributor Author

What I think I would like to do for Sprockets 4 is to fix the built in ScsscProcessor and support sassc natively inside of the sass-rails gem, we probably want to encourage people to use sassc over ruby sass due to speed improvements. I see you've contributed to the processors a bit, if you have some time to take a look at the failure rails/sprockets#323 (comment) I would appreciate it. It's very slow going for me since it's an area of the code i've never touched before.

schneems added a commit to rails/sprockets that referenced this issue Jul 21, 2016
Found they're bing used by `sassc-rails` sass/sassc-rails#64.
schneems added a commit to rails/sprockets that referenced this issue Jul 21, 2016
Found they're bing used by `sassc-rails` sass/sassc-rails#64.
schneems added a commit to rails/sprockets that referenced this issue Jul 21, 2016
Found they're bing used by `sassc-rails` sass/sassc-rails#64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants