Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sassc Ruby should detect presence of existing libsass.so #8

Closed
edward opened this issue Jun 22, 2015 · 6 comments
Closed

Sassc Ruby should detect presence of existing libsass.so #8

edward opened this issue Jun 22, 2015 · 6 comments

Comments

@edward
Copy link
Member

edward commented Jun 22, 2015

@bolandrm how would you feel about having the ext/Rakefile check for an existing libsass.so before it compiles its own? This would also involve performing the detection or setting something in SassC::Native.

I say this because having just the one built libsass.so will speed up CI times for projects that use sassc-ruby.

@bolandrm
Copy link
Member

i'm a bit fuzzy on how this would work. where does the libsass.so live? For most CIs, isn't the whole environment cleaned up after each run?

@edward
Copy link
Member Author

edward commented Jun 23, 2015

The libsass.so will live where ever lib files get installed; somewhere like /usr/local/lib depending on your environment setup.

If we can pre-install binaries of libsass.so then we won’t have to compile them every CI run.

@edward
Copy link
Member Author

edward commented Jun 26, 2015

Actually… let’s forget this for now. Gem caching should be sufficient to do what I need.

@edward edward closed this as completed Jun 26, 2015
@agis
Copy link

agis commented Jul 6, 2018

This is useful for people that don't want to use the bundled libsass. Is there any interest in moving this forward?

cc @edward @bolandrm

@edward
Copy link
Member Author

edward commented Jul 10, 2018

@agis I think it’d be neat! I didn’t follow up on this since I had to focus on other stuff urgently but it could still be helpful.

I’d be open to taking a look at a PR with the caveat that I haven’t looked at the code in 3 years and am just coming back to work after being off on parental leave for a year 😬

@ebgc
Copy link

ebgc commented Nov 19, 2018

1+

pls support this - no need to add redundancy - each gem compiling its own lib if lib exists on system already.

i.e. nokogiri supports it via NOKOGIRI_USE_SYSTEM_LIBRARIES variable

it also reduces overhead of installing compilers to system where gem has to be installed

michael-gillett pushed a commit to michael-gillett/sassc-ruby that referenced this issue Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants