Fixes #2
Closed
Fixes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Is it possible for you to add some test cases for this? Otherwise I'll write some tests and merge this weekend. |
|
Thanks! closed in favor of #3 (same commits w/ tests added) |
michael-gillett
pushed a commit
to michael-gillett/sassc-ruby
that referenced
this pull request
Apr 25, 2019
Moved a bunch of stuff around
michael-gillett
pushed a commit
to michael-gillett/sassc-ruby
that referenced
this pull request
Apr 25, 2019
moving dependencies included (fixed) into master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
bytesizewhen mallocing memory to handle multi-byte charactersASCII_8BITsince it was coming from FFI