Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade to libsass 3.5.2 to fix css imports #81

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Downgrade to libsass 3.5.2 to fix css imports #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67147df
Add failing test for css imports
deivid-rodriguez Jul 3, 2018
c948212
Downgrade to 3.5.2 to fix css imports
deivid-rodriguez Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/libsass
Open in desktop
Submodule libsass updated 24 files
+35 −21 GNUmakefile.am
+12 −8 configure.ac
+8 −17 docs/implementations.md
+10 −16 docs/unicode.md
+0 −3 include/sass/context.h
+1 −1 script/tap-runner
+2 −48 src/context.cpp
+0 −3 src/context.hpp
+1 −1 src/cssize.cpp
+0 −1 src/debugger.hpp
+15 −0 src/eval.cpp
+1 −2 src/expand.cpp
+2 −2 src/file.cpp
+2 −8 src/file.hpp
+1 −1 src/functions.cpp
+3 −3 src/inspect.cpp
+4 −4 src/operators.cpp
+9 −25 src/parser.cpp
+3 −5 src/parser.hpp
+1 −1 src/prelexer.cpp
+2 −4 src/sass.cpp
+2 −32 src/sass_context.cpp
+1 −4 src/sass_context.hpp
+5 −0 src/util.hpp
11 changes: 11 additions & 0 deletions test/engine_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,5 +267,16 @@ def test_empty_template_encoding_matches_input
output = Engine.new(input).render
assert_equal input.encoding, output.encoding
end

def test_import_plain_css
temp_file("test.css", ".something{color: red}")
expected_output = <<-CSS
.something {
color: red; }
CSS

output = Engine.new("@import 'test'").render
assert_equal expected_output, output
end
end
end
2 changes: 1 addition & 1 deletion test/native_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module NativeTest

class General < MiniTest::Test
def test_it_reports_the_libsass_version
assert_equal "3.5.4", Native.version
assert_equal "3.5.2", Native.version
end
end

Expand Down