Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to avoid absolute path to be converted to relative. #224

Merged
merged 2 commits into from
Sep 30, 2015

Conversation

alansouzati
Copy link
Contributor

This fixes #223

DCO 1.1 Signed-off-by: Alan Souza contact@alansouzati.com

@bgriffith
Copy link
Member

Hey @alansouzati - thanks for the PR. Makes sense to me - @Snugug Thoughts?

@Snugug
Copy link
Member

Snugug commented Sep 27, 2015

I'd prefer to always resolve to an absolute path. We can use https://nodejs.org/api/path.html#path_path_isabsolute_path to check to see if the path is absolute and, if it is not, go through the process we have now in full.

On Sep 27, 2015, at 12:02 AM, Ben Griffith notifications@github.com wrote:

Hey @alansouzati - thanks for the PR. Makes sense to me - @Snugug Thoughts?


Reply to this email directly or view it on GitHub.

@DanPurdy
Copy link
Member

I agree with @Snugug

@alansouzati
Copy link
Contributor Author

Fine with me, do you want me to go ahead and add this check in the code?

@DanPurdy
Copy link
Member

If you wouldn't mind @alansouzati

Thanks!

@alansouzati
Copy link
Contributor Author

I've incorporated your feedbacks in this PR.

@Snugug Snugug added this to the 1.2.3 milestone Sep 30, 2015
Snugug added a commit that referenced this pull request Sep 30, 2015
Fix to avoid absolute path to be converted to relative.
@Snugug Snugug merged commit 5f2c284 into sasstools:develop Sep 30, 2015
@DanPurdy DanPurdy modified the milestones: 1.2.4, 1.2.3, 1.3.0 Oct 5, 2015
donabrams pushed a commit to donabrams/sass-lint that referenced this pull request Nov 19, 2015
Fix to avoid absolute path to be converted to relative.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absolute configPath is being converted to relative inside sass-lint
4 participants