Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct cli tests to use bin #911

Merged
merged 3 commits into from
Oct 25, 2016
Merged

Correct cli tests to use bin #911

merged 3 commits into from
Oct 25, 2016

Conversation

bgriffith
Copy link
Member

@bgriffith bgriffith commented Oct 24, 2016 •
edited
Loading

Fixes an issue where the CLI tests would fail if the user had not symlinked sass-lint to the globals.

In progress - need to fix on Windows 🚀

<DCO 1.1 Signed-off-by: Ben Griffith gt11687@gmail.com>

@bgriffith bgriffith force-pushed the feature/local-cli branch 4 times, most recently from 0433d69 to e61f688 Compare October 24, 2016 21:42
@coveralls
Copy link

coveralls commented Oct 24, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 97.527% when pulling e61f688 on bgriffith:feature/local-cli into 47ae2e7 on sasstools:develop.

@DanPurdy
Copy link
Member

You can remove https://github.com/sasstools/sass-lint/blob/develop/.travis.yml#L9 and https://github.com/sasstools/sass-lint/blob/develop/appveyor.yml#L28 as part of this.

@coveralls
Copy link

coveralls commented Oct 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 97.529% when pulling 5585216 on bgriffith:feature/local-cli into 6fd0341 on sasstools:develop.

@coveralls
Copy link

coveralls commented Oct 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 97.529% when pulling 5585216 on bgriffith:feature/local-cli into 6fd0341 on sasstools:develop.

@DanPurdy DanPurdy added this to the 1.10 milestone Oct 25, 2016
@coveralls
Copy link

coveralls commented Oct 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 97.529% when pulling 37773be on bgriffith:feature/local-cli into cbfe9ea on sasstools:develop.

@DanPurdy DanPurdy merged commit 5b125b6 into sasstools:develop Oct 25, 2016
@DanPurdy DanPurdy deleted the feature/local-cli branch October 25, 2016 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@bgriffith @coveralls @DanPurdy