Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage #18

Merged
merged 7 commits into from
Mar 19, 2020
Merged

Improve coverage #18

merged 7 commits into from
Mar 19, 2020

Conversation

matiasg
Copy link
Collaborator

@matiasg matiasg commented Jan 2, 2018

This PR does two things:

  1. improves coverage
  2. issues warning on two close-to-be-deprecated methods

@matiasg matiasg mentioned this pull request Jan 2, 2018
Closed
@coveralls
Copy link

coveralls commented Jan 2, 2018 •
edited
Loading

Coverage Status

Coverage increased (+1.6%) to 98.467% when pulling 3d1d7b4 on improve_coverage into a2e74cf on master.

@matiasg
Copy link
Collaborator Author

matiasg commented Jan 2, 2018

@enritoomey or @slava-kerner : could you please review this PR?

@astrojuanlu
Copy link
Contributor

This got a bit old, does it deserve a rebase and a review?

@matiasg
Copy link
Collaborator Author

matiasg commented Apr 27, 2018

I'll give it some love ASAP.

enritoomey
enritoomey approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@enritoomey enritoomey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo ok por mi. No termino de entender "test_integrate" pero igual te doy +1 por "test_weights_change_in_qmethod"

@enritoomey enritoomey merged commit f650bdf into master Mar 19, 2020
matiasg added a commit that referenced this pull request Jul 27, 2020
@matiasg
# This is a combination of 24 commits.
e4fada6 
# This is the 1st commit message:

pin coveralls version

# This is the commit message #2:

rever change of pytest-coverage. Pin python-coverage

# This is the commit message #3:

just as a test, remove coveralls

# This is the commit message #4:

remove also cov from script 🤦

# This is the commit message #5:

pin pytest version

# This is the commit message #6:

pin hypothesis version

# This is the commit message #7:

pin hypothesis to 3.55.1 now

# This is the commit message #8:

do not install pytest-coverage

# This is the commit message #9:

pin pytest-coverage

# This is the commit message #10:

install pinned coverage, do not install pytest-coverage :'(

# This is the commit message #11:

pin attr

# This is the commit message #12:

attr is attrs

# This is the commit message #13:

travis, please tell me attr version

# This is the commit message #14:

go back to original setup.py

# This is the commit message #15:

exclude coveralls from 3.4 & 3.5. Try 1

# This is the commit message #16:

use [] instead of test

# This is the commit message #17:

install pytest 5.4.3

# This is the commit message #18:

travis tell me something

# This is the commit message #19:

please do tell

# This is the commit message #20:

ooohhh?

# This is the commit message #21:

oh 2

# This is the commit message #22:

oh 3

# This is the commit message #23:

oh 4

# This is the commit message #24:

oh 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enritoomey enritoomey enritoomey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matiasg @coveralls @astrojuanlu @enritoomey