Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterable imported from collections.abc #27

Closed
wants to merge 4 commits into from

Conversation

matiasg
Copy link
Collaborator

@matiasg matiasg commented Jul 23, 2020

closes #26

@enritoomey
Copy link
Contributor

@matiasg entendés por qué falla el test en python3.5? supongo que no tiene que ver con el cambio especifico de este MR... pero no estoy seguro.

@matiasg
Copy link
Collaborator Author

matiasg commented Jul 24, 2020

@enritoomey Es un berenjenal de versiones :-(
Estoy en una branch aparte intentando pinnear distintas versiones de paquetes para que se parezca a la última vez que buildeó bien.
Tenemos 5 builds con versiones diferentes. Hay 32 posibilidades de pasa/falla.
Ya estoy por cubrir las 32.
Qué pesadilla es mantener python 3.4!

@matiasg
Copy link
Collaborator Author

matiasg commented Jul 27, 2020

@enritoomey estoy haciendo otro PR donde se arregla el tema de las verisones: #29
Metamos primero #29 y después este si te parece. Y si todavía estás ahí :-)

@enritoomey
Copy link
Contributor

@matiasg ya le hice review a #29, cuando seguimos con esto.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.467% when pulling 3f3cc2f on fix_deprecated_import into b5cd3aa on master.

@astrojuanlu
Copy link
Contributor

"En mi fork funciona" #33

@matiasg
Copy link
Collaborator Author

matiasg commented Aug 10, 2020

@astrojuanlu : mergeamos #33 y cerramos éste?

Iterable imported from collections.abc (take II)
@astrojuanlu
Copy link
Contributor

Superseded by #33 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update deprecated import
4 participants