Add method to get UUID as string without dashes. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuid.go
Outdated
| hex.Encode(buf[16:20], u[8:10]) | ||
| hex.Encode(buf[20:], u[10:]) | ||
|
|
||
| return string(buf) |
There was a problem hiding this comment.
is it better to use hex.EncodeToString(u.Bytes())?
There was a problem hiding this comment.
Yes, it is better and more coincise. Thank you for the advice. Tomorrow I will push it.
iaroslav-ciupin
approved these changes
Oct 4, 2017
|
@limoli Try to contact repo owner or people with write access to this repo and ask them to review and merge this PR |
|
This is a pointless change as it can be done and used outside of this package. I am against it as it pollutes the code with a method which is not compliant with the standard uuid representation. |
|
Closing as this method doesn't produce much value for a library in my opinion. |
|
I need this change too. Dashless uuid strings aren't that uncommon in the real world. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need the possibility to have an UUID string without dashes in my project.
I didn't want to use strings package to manage it since it could be a new simple functionality.