Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discord): confuse of required argument #272

Merged
merged 1 commit into from
May 14, 2024

Conversation

yhx-12243
Copy link
Contributor

  • I think the required argument of options in Universal.Command denotes whether a value should be present,
  • however, the required argument in Discord denotes whether this option should be present.

* I think the `required` argument of options in `Universal.Command` denotes whether a *value* should be present,
* however, the `required` argument in Discord denotes whether *this option* should be present.
@shigma shigma merged commit 48bdc78 into satorijs:master May 14, 2024
@yhx-12243 yhx-12243 deleted the discord-required branch June 4, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants