This repository has been archived by the owner on Nov 27, 2022. It is now read-only.
feature: add Collapsible TabView #1096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PedroBern Hi! Nice work. Currently collapsible tab view scrolls only when tab is touched, but not a header. Could you please tell how to make header and tab bar responsive for scrolling? It's critical for cases when header height is greater than screen height. |
|
@pskryuchkov use one of the following packages instead of this or:
There are instructions on the readme on how to scroll on the header, as you want. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit
I have published a package with this feature. If this PR ever gets merged, I probably will archive it. @satya164 please if you are going to review it, let me know first, so I can update this PR to the latest of the published package, in the meanwhile I'm developing there. Thanks for this awesome lib.
Motivation
Same motivation as #1079 and #411, but solving with a different approach. Just like @jehartzog, I started from this medium article by @JungHsuan and made some great improvements to make it reusable.
My goal was to build a
CollapsibleTabViewkeeping the same API asTabView, in fact, if someone uses the new component proposed on this PR without a header, it will be the same as theTabView.@satya164 please let me know your thoughts on this. I'm available to discuss and make changes.
Related: #901, #791, #735