middleware(prom): add customizable label for http metrics #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choraden
force-pushed
the
hg/metrics_http_req_label
branch
from
8f0415f
to
65aa050
Compare
mmatczuk
reviewed
Mar 19, 2024
middleware/prometheus.go
Outdated
Comment on lines
58
to
59
| label string | ||
| labeler func(*http.Request) string |
There was a problem hiding this comment.
It would be better as a type.
Choraden
force-pushed
the
hg/metrics_http_req_label
branch
from
65aa050
to
45dab3f
Compare
mmatczuk
reviewed
Mar 20, 2024
http_proxy.go
Outdated
| @@ -94,6 +94,7 @@ type HTTPProxyConfig struct { | |||
| ConnectTimeout time.Duration | |||
| ReadLimit SizeSuffix | |||
| WriteLimit SizeSuffix | |||
| PromHTTPOpts []middleware.PrometheusOpt | |||
There was a problem hiding this comment.
I'd add it to PromConfig tbh
There was a problem hiding this comment.
Adding it here makes no sense. It is very specific, while PromConfig is widely used across all components.
|
What is the status of this PR? |
|
Looks like it's good to go. Let's discuss it during our meeting. |
mmatczuk
force-pushed
the
hg/metrics_http_req_label
branch
from
d4e27e2
to
cb37672
Compare
It can be used to partition the metrics by custom conditions. e.g. Label direct/tunnel mode in SC5. PrometheusOpt was chosen to ensure compatibility with existing prom instances.
Choraden
force-pushed
the
hg/metrics_http_req_label
branch
from
cb37672
to
60845d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be used to partition the metrics by custom conditions. e.g. Label direct/tunnel mode in SC5.
PrometheusOpt was chosen to ensure compatibility with existing prom instances.