[sauceConnectLoader] we should await fs.rename & fs.chmod to avoid race conditions #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sauceConnectLoader] we should await fs.rename & fs.chmod to avoid race conditions
Description
saucelabsnpm package downloadsscbinary viaverifyAlreadyDownloadedasync function before actually invoking it.However, some of the file system operations are not properly awaited so if they are slow,
spawncan happen before making surescbinary is ready in the correct path.Note that this type of bugs are easily detected by static checks if we use TypeScript + ESLint (no-floating-promises is part of
recommended-type-checked)Types of Changes
What types of changes does your code introduce? Keep the ones that apply:
Tasks
List of tasks you will do to complete the PR
Review
List of tasks the reviewer must do to review the PR
Deployment Notes
These should highlight any db migrations, feature toggles, etc.
Nothing to care