Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set global timeout conditionally #229

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix: Set global timeout conditionally #229

merged 1 commit into from
Aug 31, 2023

Conversation

alexplischke
Copy link
Contributor

@alexplischke alexplischke commented Aug 30, 2023

Set the global timeout conditionally, that is, the user didn't set one in their native playwright config file. This allows the user to retain their existing timeout configuration and still be able to override it if necessary via saucectl.

This fix addresses the following issues:

  • The default timeout for the entire execution was incorrectly set as the test level timeout
  • The default acted as a constant override, rather than default, causing customer provided values inside the native playwright config to be overridden at all times
  • The user had to set both the globalTimeout and the regular timeout, so that timeout wasn't overridden by the default

Here's an example job where I set the test timeout via the playwright configuration file (forcing it to fail): https://app.saucelabs.com/tests/2a7e89f34ea94ff599d84d8ad3d3eb61

@alexplischke alexplischke added the bug Something isn't working label Aug 30, 2023
@alexplischke alexplischke marked this pull request as ready for review August 30, 2023 22:59
@alexplischke alexplischke requested a review from a team as a code owner August 30, 2023 22:59
@alexplischke alexplischke merged commit 62ed9ca into main Aug 31, 2023
29 checks passed
@alexplischke alexplischke deleted the DEVX-2525 branch August 31, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants