fix: Set global timeout conditionally #229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the global timeout conditionally, that is, the user didn't set one in their native playwright config file. This allows the user to retain their existing timeout configuration and still be able to override it if necessary via saucectl.
This fix addresses the following issues:
globalTimeout
and the regulartimeout
, so thattimeout
wasn't overridden by the defaultHere's an example job where I set the test timeout via the playwright configuration file (forcing it to fail): https://app.saucelabs.com/tests/2a7e89f34ea94ff599d84d8ad3d3eb61