Extract UI related config params into a UIConfig type #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Config{..}
type was mixing up config params required for the job-runner along with the config params required for the web-UI.Config{..}
type forces one to define unnecessary config params if only the web-ui needs to be started or only the job-runner needs to be startedSub-problem
OddJobs.Cli
is very confusing. It was confusing even for me when I wanted to write a custom CLI for some purpose.Solution
Types.UIConfig{..}
Cli.CliType
that allows one to easily start only the job-runner, only the web-ui, or both.OddJobs.Cli
parses the command-line and builds aConfig -> Config
(orUIConfig -> UIConfig
) function that overrides the default config based on command-line arguments. This function can be passed tomkConfig
ormkUIConfig
. This avoid the "callback-withing-callback" style to some extent.