Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Error handling #81

Merged
merged 22 commits into from
Nov 2, 2018
Merged

Improved Error handling #81

merged 22 commits into from
Nov 2, 2018

Conversation

navimakarov
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 1, 2018 •
edited
Loading

Codecov Report

Merging #81 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   42.45%   42.46%   +<.01%     
==========================================
  Files          27       27              
  Lines        3474     3478       +4     
==========================================
+ Hits         1475     1477       +2     
- Misses       1999     2001       +2
Impacted Files Coverage Δ
src/lib_ccaligner/read_wav_file.cpp 31.85% <66.66%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af09394...cbee414. Read the comment docs.

saurabhshri
saurabhshri requested changes Nov 1, 2018
View reviewed changes
Copy link
Owner

@saurabhshri saurabhshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the same check for twoBytesToInt. Also, please document the unit tests. It should be apparent of what's happening.

saurabhshri
saurabhshri requested changes Nov 2, 2018
View reviewed changes
src/lib_ccaligner/read_wav_file.cpp Outdated Show resolved Hide resolved
test/src/twoBytesToInt.cpp Outdated Show resolved Hide resolved
saurabhshri
saurabhshri requested changes Nov 2, 2018
View reviewed changes
test/src/twoBytesToInt.cpp Outdated Show resolved Hide resolved
saurabhshri
saurabhshri requested changes Nov 2, 2018
View reviewed changes
Copy link
Owner

@saurabhshri saurabhshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! :) Just some super-minor changes before merging.

test/src/twoBytesToInt.cpp Outdated Show resolved Hide resolved
test/src/twoBytesToInt.cpp Outdated Show resolved Hide resolved
test/src/twoBytesToInt.cpp Outdated Show resolved Hide resolved
src/lib_ccaligner/read_wav_file.cpp Show resolved Hide resolved
@saurabhshri saurabhshri merged commit a3fea1e into saurabhshri:master Nov 2, 2018
@navimakarov navimakarov mentioned this pull request Dec 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhshri saurabhshri saurabhshri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navimakarov @saurabhshri