Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build (due to libmseed breaking ABI in v3) #1

Merged
merged 3 commits into from
May 18, 2021

Conversation

acarapetis
Copy link
Contributor

The HEAD of https://github.com/iris-edu/libmseed now points to the new libmseed version 3, which has changed the ABI from version 2 (which is what miniseed-rs is clearly expecting to link with). This PR modifies build.rs to explicitly check out the libmseed branch 2.x, allowing linking to succeed.

@savage13
Copy link
Owner

I will merge this soon. Would it be worth the effort to upgrade this crate to the 3.x ABI?

@acarapetis
Copy link
Contributor Author

acarapetis commented Feb 19, 2021

I'm sure it would be useful to someone at some point. For my purposes I'm perfectly happy with 2.x.

Also, maybe I'm missing something but seemed like the functionality of this crate was limited to reading the first record from each file/buffer? I've added a couple structs to allow stream processing of entire files in https://github.com/acarapetis/miniseed-rs/tree/io-helpers. There are no tests or documentation yet, but I could add some next week if you're interested in merging that too.

@HerrMuellerluedenscheid
Copy link
Contributor

Probably this should be kept in a branch 2.x rather than master.

@HerrMuellerluedenscheid
Copy link
Contributor

I will merge this soon. Would it be worth the effort to upgrade this crate to the 3.x ABI?

See #3

@savage13 savage13 merged commit 7b96ec9 into savage13:master May 18, 2021
@savage13
Copy link
Owner

I added the changes from acarapetic/miniseed-rd#99c264a to read and write multiple segments from miniseed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants