Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: token caching #287

Merged
merged 1 commit into from
Oct 6, 2023
Merged

feat: token caching #287

merged 1 commit into from
Oct 6, 2023

Conversation

Muchogoc
Copy link
Member

@Muchogoc Muchogoc commented Oct 6, 2023

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Pull Request Test Coverage Report for Build 6429072685

  • 8 of 31 (25.81%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 81.113%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/clinical/presentation/config.go 4 7 57.14%
pkg/clinical/presentation/rest/auth_middleware.go 4 24 16.67%
Files with Coverage Reduction New Missed Lines %
pkg/clinical/presentation/rest/auth_middleware.go 1 6.38%
Totals Coverage Status
Change from base Build 6403254441: -0.3%
Covered Lines: 5278
Relevant Lines: 6507

💛 - Coveralls

@Salaton Salaton merged commit 8786680 into develop-v2 Oct 6, 2023
5 of 6 checks passed
@Salaton Salaton deleted the cache-auth-token branch October 6, 2023 08:45
KathurimaKimathi added a commit that referenced this pull request Dec 14, 2023
* add conditions to patient timeline (#276)

* fix: fix listing of patient conditions (#278)

* fix: check encounter finished status when creating allergies (#279)

* feat: add record blood sugar api (#280)

* feat: add api to fetch a patient's blood sugar observation (#281)

* add last menstrual period vital (#283)

* add diastolic blood pressure observation (#284)

* adds fetching patient's diastolic blood pressure (#286)

* feat: token caching (#287)

* feat: add composition resource (#282)

* list patient's compositions (#289)

* query observations with encounterID filter (#290)

* query observations with encounterID filter

* updates

* query conditions with encounterID (#291)

* query compositions with encounterID (#292)

* feat: add date filter query on observations (#293)

- rebased - has observations date filter changes ONLY

* feat: add date filter on conditions (#294)

- adds date filter as a search param for conditions

---------

Co-authored-by: EspiraMarvin <espiramarvin@gmail.com>
Co-authored-by: Salaton <nairouasalaton@gmail.com>
Co-authored-by: Charles Muchogo <dev@muchogo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants